feat: implement threaded message strategy for Slack notifier#5227
Draft
santiagofn wants to merge 4 commits intoprometheus:mainfrom
Draft
feat: implement threaded message strategy for Slack notifier#5227santiagofn wants to merge 4 commits intoprometheus:mainfrom
santiagofn wants to merge 4 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Santiago Fernández Núñez <santiago.nunez@nubank.com.br>
Signed-off-by: Santiago Fernández Núñez <santiago.nunez@nubank.com.br>
…gies Signed-off-by: Santiago Fernández Núñez <santiago.nunez@nubank.com.br>
Signed-off-by: Santiago Fernández Núñez <santiago.nunez@nubank.com.br>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of a series implementing threaded message support for the Slack notifier. Full picture: #5150. Depends on #5224, #5225, and #5226.
Summary
Implements the core threaded message strategy. When
message_strategy: threadis configured, a parent summary message is posted first, and subsequent firing/resolved notifications are posted as thread replies. The strategy uses the notification log to persist the parent message'stsandchannelacross alert state changes, enabling correct threading even across alert manager restarts.Also implements support for updating the parent message emoji and text on resolution when
resolve_emojiorupdate_parent_on_resolveare configured.